Skip to content

Commit

Permalink
ext/soap: fix make check being invoked in ext/soap
Browse files Browse the repository at this point in the history
On NixOS we run `make` & `make check` inside `ext/soap` which broke the test
like this:

    001+ Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing WSDL: Couldn't load from 'ext/soap/tests/gh15711.wsdl' : failed to load "ext/soap/tests/gh15711.wsdl": No such file or directory
    002+  in /build/php-8.3.13/ext/soap/tests/gh15711.php:29
    003+ Stack trace:
    004+ #0 /build/php-8.3.13/ext/soap/tests/gh15711.php(29): SoapClient->__construct('ext/soap/tests/...', Array)
    005+ #1 {main}
    006+   thrown in /build/php-8.3.13/ext/soap/tests/gh15711.php on line 29

Fix is to make the path dependant on `__DIR__` as it's the case in other
testcases including WSDLs.

Closes phpGH-16733.
  • Loading branch information
Ma27 authored and nielsdos committed Nov 8, 2024
1 parent af8ebb1 commit 73c4fa0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ PHP NEWS
- PDO:
. Fixed memory leak of `setFetchMode()`. (SakiTakamachi)

- SOAP:
. Fix make check being invoked in ext/soap. (Ma27)

07 Nov 2024, PHP 8.3.14RC1

- Cli:
Expand Down
2 changes: 1 addition & 1 deletion ext/soap/tests/gh15711.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class TestSoapClient extends SoapClient {
}
}

$client = new TestSoapClient('ext/soap/tests/gh15711.wsdl', ['classmap' => ['book' => 'book']]);
$client = new TestSoapClient(__DIR__ . '/gh15711.wsdl', ['classmap' => ['book' => 'book']]);

echo "--- Test with backed enum ---\n";

Expand Down

0 comments on commit 73c4fa0

Please sign in to comment.