Add support for installing default global npm packages on nvm install #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until this gets merged, how are you able work around installing global npm packages |
|
Sorry, I usually never install global packages, but I'd like to see this merged still. It's just that I need a bit of time to sit down and understand what this does and make sure it does it in a way that makes sense. 🙏 |
jorgebucaran
reviewed
Jun 8, 2022
functions/nvm.fish
Outdated
Comment on lines
100
to
103
| if not set -q $nvm_default_packages[1] | ||
| set install_default_packages true | ||
| end | ||
|
|
There was a problem hiding this comment.
@kallja What's the purpose of this code?
jorgebucaran
requested changes
Jun 8, 2022
functions/nvm.fish
Outdated
Comment on lines
116
to
120
| if test $install_default_packages | ||
| echo "Installing default npm packages: $nvm_default_packages" | ||
| npm install -g $nvm_default_packages | ||
| end | ||
| end |
There was a problem hiding this comment.
Think we could boil this down to:
if set --query nvm_default_packages[1]
npm install --global $nvm_default_packages
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #178