Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support #[derive(IntoHeap)] for types that don't have lifetime parameters #21

Open
jorendorff opened this issue Jul 2, 2017 · 2 comments
Open

Support #[derive(IntoHeap)] for types that don't have lifetime parameters #21

jorendorff opened this issue Jul 2, 2017 · 2 comments

Comments

@jorendorff
Copy link
Owner

It wouldn't even be hard.
@fitzgen
Copy link
Collaborator

fitzgen commented Jul 2, 2017

Would this allow us to remove GcLeaf? Because if nothing is using the 'h lifetime, then it can't have any GC references

@fitzgen fitzgen mentioned this issue Jul 18, 2017
Closed
@jorendorff
Copy link
Owner Author

I don't know about remove; you may want to have heap types with fields of types you didn't define yourself.

jorendorff added a commit that referenced this issue Jul 26, 2017
@jorendorff
Remove the lifetime parameter from Storage types.
0521404 
The hack needed in gc-cell-derive to make this work is moderately gross,
but Storage types really should not have a lifetime parmater—it makes no
sense.

The IntoHeapBase::In associated type now has a 'static bound.

Support for PhantomData is reined in. I hope to delete this entirely,
eventually; the only reason to use a PhantomData field in the heap is
issue #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @jorendorff