Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

Check api level before clearing shortcut items #37

Merged
merged 1 commit into from
May 24, 2017
Merged

Check api level before clearing shortcut items #37

merged 1 commit into from
May 24, 2017

Conversation

AndrewJack
Copy link
Contributor

@AndrewJack AndrewJack commented May 24, 2017

Check api level before calling removeAllDynamicShortcuts()

Fix crash:

java.lang.RuntimeException Could not invoke ReactAppShortcuts.clearShortcutItems 
    BaseJavaModule.java:382 com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke
    JavaModuleWrapper.java:138 com.facebook.react.cxxbridge.JavaModuleWrapper.invoke
    NativeRunnable.java:-2 com.facebook.react.bridge.queue.NativeRunnable.run
    Handler.java:733 android.os.Handler.handleCallback
    Handler.java:95 android.os.Handler.dispatchMessage
    MessageQueueThreadHandler.java:31 com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage
    Looper.java:136 android.os.Looper.loop
    MessageQueueThreadImpl.java:208 com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run
    Thread.java:841 java.lang.Thread.run

Caused: java.lang.NoClassDefFoundError android.content.pm.ShortcutManager 
    AppShortcutsModule.java:121 com.reactNativeQuickActions.AppShortcutsModule.clearShortcutItems
    Method.java:-2 java.lang.reflect.Method.invokeNative
    Method.java:515 java.lang.reflect.Method.invoke
    BaseJavaModule.java:368 com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke
    JavaModuleWrapper.java:138 com.facebook.react.cxxbridge.JavaModuleWrapper.invoke
    NativeRunnable.java:-2 com.facebook.react.bridge.queue.NativeRunnable.run
    Handler.java:733 android.os.Handler.handleCallback
    Handler.java:95 android.os.Handler.dispatchMessage
    MessageQueueThreadHandler.java:31 com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage
    Looper.java:136 android.os.Looper.loop
    MessageQueueThreadImpl.java:208 com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run
    Thread.java:841 java.lang.Thread.run

@jordanbyron
Copy link
Owner

Looks good to me. @huangmr thoughts?

@jordanbyron jordanbyron merged commit f194d48 into jordanbyron:master May 24, 2017
@jordanbyron
Copy link
Owner

@AndrewJack @huangmr thanks fellas!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants