Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] fix help buttons #468

Merged
merged 2 commits into from
Oct 2, 2021
Merged

[4.0] fix help buttons #468

merged 2 commits into from
Oct 2, 2021

Conversation

Bakual
Copy link

@Bakual Bakual commented Sep 27, 2021

Pull Request for Issue joomla/joomla-cms#35662 (comment)

Summary of Changes

Removing JHELP language strings which were already not present in the INI files. Using hardcoded references like we do in core now.
Adding information for help buttons in categories views and weblink edit form
Removed one help button for the single weblink menuitem as there is currently no help page for that one.

Testing Instructions

Try the various help buttons,

Expected result

they should all work now.

Actual result

Some are missing, some are giving a 404 error

Documentation Changes Required

None

@ChristineWk
Copy link

ChristineWk commented Sep 28, 2021

Can't test it.
Hv changed Github Repository of Joomla Patch Tester to:

patchtester-weblinks

(After checking & fetching) Got the list of previous issuing tracker, but not from Web Links.

Checked also: https://github.com/joomla-extensions/weblinks (Part of Patchtester Component)

Checking below, I get
404 RuntimeException

Invalid Issue

https://issues.joomla.org/tracker/weblinks/468

@Bakual
Copy link
Author

Bakual commented Sep 28, 2021

I honestly don't know how you can test Weblinks.

@joomdonation joomdonation merged commit 6c30c95 into joomla-extensions:4.0-dev Oct 2, 2021
@joomdonation
Copy link
Contributor

Thanks ! Now I understand how help works :D.

Honestly, I don't know how to use patch tester to test weblinks, too, so I applied the changes manually to test it. Will try to play with patch tester later to see if it could be used to test weblinks PR.

Thanks @Bakual for the PR and thanks @ChristineWk for willing to help with testing.

@Bakual Bakual deleted the 4_FixHelp branch October 3, 2021 11:13
@Bakual
Copy link
Author

Bakual commented Oct 3, 2021

Thanks ! Now I understand how help works :D.

Honestly, I don't know how to use patch tester to test weblinks, too, so I applied the changes manually to test it. Will try to play with patch tester later to see if it could be used to test weblinks PR.

Thanks @Bakual for the PR and thanks @ChristineWk for willing to help with testing.

There is a third variant for help screens where the extension installs the help files directly with the extension. I don't understand yet how that works, probably broken anyway 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants