Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix adapting view categories to the core categories view #467

Merged
merged 4 commits into from
Oct 31, 2021

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Sep 25, 2021

Pull Request for Issue # .

Summary of Changes

Some changes were lost during lat commits.
This PR adapts again the view categories of weblinks to categories of content.

Testing Instructions

Make a tree of categories for example
grafik

Add description and image to categories as you like.

Add a menuitem of type categories to your menu

Expected result

grafik

@joomdonation
Copy link
Contributor

I tried to test this but when I applied the change here, the expand icon is displayed in wrong position. See the attached screenshot for Content Categories and Weblinks Categories:

  • For content categories, the expand icon is displayed at the right

CT-Categories

  • For weblinks categories, the explain icon is at the bottom of parent category description

WL-Categories

Also, I think we should use a different css class for com_weblinks instead of using com-content-categories__items . Could you please think about it and find a solution?

@chmst
Copy link
Contributor Author

chmst commented Oct 9, 2021

Could you please re-test?

Chenages are: The button is always in the first line, top right. So the following descriptopn and / or image have no influence
grafik

@joomdonation
Copy link
Contributor

So I tested it and it worked well. The reasons I have not merged this is because:

  • I don't know why we have to use com_content as a prefix of some css class in our code.
  • I want to wait a to see what's final decision with the PR Fix layout article categories list as tree joomla/joomla-cms#35114 for Joomla core. With your PR, the layout code is different with the layouts which we are using in Joomla core at the moment. I think the layout should be consistent with the layout which we are using in other extensions in core.

@chmst
Copy link
Contributor Author

chmst commented Oct 30, 2021

I suggest to merge this - it is better than now.
We keep the classes with com-content as also com_contact uses them. They are used for categories views.

weblinks categories are slightly different form content categories, but should be displayed now correctly.

@joomdonation joomdonation merged commit 73ff284 into joomla-extensions:4.0-dev Oct 31, 2021
@joomdonation
Copy link
Contributor

OK. I trust you for layout stuffs. Let's move on :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants