Replace pr #460, add empty state #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @chmst. Tested and it looks good except the Empty Trash button still shown on empty state while it should not. But I will add a separate commit to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request replaces #460
Summary of Changes
Pull Request for Issue # .
Summary of Changes
If no weblink exists, the empty state screen appears as in other core components.
Testing Instructions
Make a fresh installation of weblinks or delete all weblinks.
Expected result
The empty state screen appears.
Actual result
The overview appears with an not-found-alert
Documentation Changes Required
yes