Make work queue limits configurable in QueuePairBuilder. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it's been a very long time since I used this myself, so I honestly don't remember. Seems fine to allow configuring them though, thanks! |
jonhoo
approved these changes
Nov 25, 2024
|
Releasing in #43 |
jonhoo
added a commit
that referenced
this pull request
Dec 27, 2024
ibverbs-sys 0.3.0+55.0: 55.0 + bindgen + pub consts + non-in-place build ibverbs 0.9.0: -sys 0.3.0 + configurable work queue limits rdma-core bump is for linux-rdma/rdma-core#1485 bindgen bump is for harryfei/which-rs#104 Includes #38, #39, #41, and #42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In create_qp, max_send_wr and max_recv_wr are set to a fixed value of 1. Does this have a specific reason? I would like to use larger values in my application.