Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and deprecated functions #99

Closed
wants to merge 8 commits into from

Conversation

al8n
Copy link

@al8n al8n commented Nov 18, 2021

Hi, when I write my project depending on both flurry and crossbeam-epoch, I meet this error.

error[E0308]: mismatched types
   --> src/store/flurry_store.rs:348:26
    |
348 |         map.insert(1, 1, &g);
    |                          ^^ expected struct `flurry::epoch::Guard`, found struct `crossbeam_epoch::Guard`
    |
    = note: expected reference `&flurry::epoch::Guard`
               found reference `&crossbeam_epoch::Guard`
    = note: perhaps two different versions of crate `crossbeam_epoch` are being used?

I found some dependencies in this crate that are out-of-date, so I update the dependencies and deprecated functions.


This change is Reviewable

@al8n
Copy link
Author

al8n commented Nov 19, 2021

Hi, @jonhoo. I have no idea why the tarpaulin test failed, could you give a review? Thanks!

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of mostly smaller notes.

@al8n al8n requested a review from jonhoo November 21, 2021 12:14
@al8n
Copy link
Author

al8n commented Nov 21, 2021

Hi, jonhoo. Thanks for your suggestions, all suggestions have been applied now.

@ibraheemdev
Copy link
Collaborator

Deps were updated in #105, and the deprecated functions were fixed as part of #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants