-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the option to automatically call the lightning-logger LWC #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one corresponds to a specific Salesforce feature that's optionally used by Nebula Logger
…simplify manual testing efforts
…lesforce's lightning-logger LWC when logging via lightning components. This then creates a "Lightning Logger" event in Event Monitoring
… lightning-logger, removed some problematic settings in some of the new scratch def files
…r Spanish as the user's language The new platform cache scratch def uses Japanese as the user's language, resulting in some profile queries to fail
…oid the dev hub's limit of 3 active scratch orgs I'm keeping 1 of 3 available for myself for dev Also stopped using the demo org for secondary scratch orgs - it has a very low limit of only 6 scratch org creations per day, so it's not reliable (Nebula Logger's dev hub has an increased daily limit)
…r, removed unnecessary access to FlowLogger in perm set LoggerLogCreator
a0fb6dc
to
c7622e5
Compare
40d9775
to
b63b3b6
Compare
….js and ComponentLogger.cls Now browser details are represented as an object in both JS and Apex, and some old deprecated properties have been removed Also added some extra jest tests to validate that the browser details are being properly set
3e76a52
to
75e026b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 93.18% 93.16% -0.02%
==========================================
Files 67 67
Lines 6939 6935 -4
Branches 197 198 +1
==========================================
- Hits 6466 6461 -5
- Misses 445 446 +1
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
Feature: Scenario-Based Logging
Items related to Logger.setScenario(), LoggerScenarioRule__mdt, etc.
Layer: Configuration
Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type
Layer: Logger Engine
Items related to the core logging engine
Logging Source: Lightning Components
Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura)
Salesforce Feature: Event Monitoring
Items that integrate with/leverage features provided by Salesforce's Event Monitoring tool
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Unlocked Package Changes
Resolved #702 2 by adding the optional ability to automatically call Salesforce's
lightning-logger
LWC when logging via lightning components. This then creates a "Lightning Logger" event in Event Monitoring. These events & thelightning-logger
LWC were made generally available (GA) in Salesforce's Spring '24 release.Important Note: for this new feature to work...
Another Important Note: for orgs without Event Monitoring (or with Event Monitoring disabled), essentially nothing will actually happen when this feature is enabled in Nebula Logger in your orgs. It's a fully optional feature specifically for orgs that do have Event Monitoring.
For orgs with Event Monitoring setup:
To enable this in Nebula Logger org-wide, or for a particular profile/user, set the new settings field
LoggerSettings__c.IsJavaScriptLightningLoggerEnabled__c
totrue
(default isfalse
)To enable this in Nebula Logger for a particular scenario (using scenario-based logging), set the new scenario rule field
LoggerScenarioRule__mdt.IsJavaScriptLightningLoggerEnabled__c
totrue
(default isnull
)Once
lightning-logger
has been enabled in Nebula Logger, the JavaScript representation of Nebula Logger's log entry will be logged usinglightning-logger
. From there, Salesforce will do 2 things:New
lightning-logger
console statements will automatically be added your browser's console (just after Nebula Logger's own console statements).New "Lightning Logger" events will automatically be added in Event Monitoring. You can view these events under
Setup
→Event Monitoring
→Event Log File Browser
A few small scope creep items that are also included:
logEntryBuilder.js
andComponentLogger.cls
Logger
where aSystem.debug()
statement for scenario-based logging was using the wrong variableLoggerLogCreator
permission set to remove unnecessary access to the Apex classFlowLogger
Dev/Pipeline Changes
Added a new bash script to automate setting up a new dev scratch org
Upgraded to v4 of the codecov action in
build.yml
Upgraded to sf rc v2.56.6 to use the new
--concise
flag onsf apex test run
Removed an old/duplicate Experience Cloud site that was used by the pipeline
Added Apex class access to 2 Experience Cloud Guest User profiles to simplify manual testing efforts
Created additional scratch def files & added them to
build.yml
- each one corresponds to a specific Salesforce feature that's optionally used by Nebula Logger, including a new one for Event Monitoring, to test the usage oflighting-logger
. The pipeline only creates 2 at a time to avoid the dev hub's limit for active scratch orgs.lightning-logger
, which stores data in Event Monitoring.