Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[One .NET] fix libmono-profiler-aot.so recording
I found when I went to update the AOT profile in .NET MAUI: https://github.com/jonathanpeppers/android-profiled-aot dotnet/maui#4355 The profiler crashed with: 01-27 11:10:16.119 28922 28922 W monodroid: Creating public update directory: `/data/user/0/com.androidaot.MauiApp1/files/.__override__` ... 01-27 11:10:16.119 28922 28922 W monodroid: Initializing profiler with options: aot:port=9999output=/data/user/0/com.androidaot.MauiApp1/files/.__override__/profile.aotprofile 01-27 11:10:16.119 28922 28922 W monodroid: Looking for profiler init symbol 'mono_profiler_init_aot'? 0x7325b6355c 01-27 11:10:16.119 28922 28922 E mono-prof: Could not create AOT profiler output file 'output.aotprofile': Read-only file system But the directory was writeable? adb shell run-as com.androidaot.MauiApp1 touch files/.__override__/foo After some digging, it turned out appending `,` to this line fixed the issue: https://github.com/xamarin/xamarin-android/blob/b7a368a27667c69117f64be81050403f2d5c8560/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Application.targets#L45 What happened was we lost a `,` somewhere in this commit: dotnet@f73a323 To fix this: 1. Prepend a `,` 2. I found a way to actually enable tests for Profiled AOT in .NET 6 by downloading binaries from my Github repo.
- Loading branch information