Skip to content

Commit

Permalink
Use explicit PendingIntents for notification actions (#1190)
Browse files Browse the repository at this point in the history
Starting with Android 14, implicit intents are restricted for internal app components. This commit explicitly sets the package name for PendingIntents used as notification actions to ensure compatibility with the behavior changes outlined in:
https://developer.android.com/about/versions/14/behavior-changes-14#security
  • Loading branch information
roberi authored Jul 9, 2024
1 parent b5de26b commit cf3b059
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/src/main/org/runnerup/notification/GpsBoundState.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public GpsBoundState(Context context) {
PendingIntent pi = PendingIntent.getActivity(context, 0, i, intentFlags);

Intent startIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.START_ACTIVITY);
PendingIntent pendingStart = PendingIntent.getBroadcast(
context, 0, startIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/org/runnerup/notification/OngoingState.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ public OngoingState(Formatter formatter, WorkoutInfo workoutInfo, Context contex
PendingIntent pi = PendingIntent.getActivity(context, 0, i, intentFlags);

Intent lapIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.NEW_LAP);
PendingIntent pendingLap = PendingIntent.getBroadcast(
context, 0, lapIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);

Intent pauseIntent = new Intent()
.setPackage(context.getPackageName())
.setAction(Constants.Intents.PAUSE_RESUME);
PendingIntent pendingPause = PendingIntent.getBroadcast(
context, 0, pauseIntent, PendingIntent.FLAG_UPDATE_CURRENT | intentFlags);
Expand Down

0 comments on commit cf3b059

Please sign in to comment.