Base64 Support #369
Merged
Base64 Support #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new optional module to house the code. Add a new `CharacterSet` trait, which is used to encode the different character sets with multiple unique types. Add a basic test. Missing: * More tests for the other character sets. * Rustdoc documentation * Changelog entries * serde_as Guide entry
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 76.88% 77.23% +0.35%
==========================================
Files 45 47 +2
Lines 2708 2768 +60
==========================================
+ Hits 2082 2138 +56
- Misses 626 630 +4
Continue to review full report at Codecov.
|
Properly document the new `Base64` type and formats.
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
369: Base64 Support r=jonasbb a=jonasbb Create a new optional module to house the code. Add a new `CharacterSet` trait, which is used to encode the different character sets with multiple unique types. Add a basic test. Missing: * [x] More tests for the other character sets. * [x] Rustdoc documentation * [x] Changelog entries * [x] serde_as Guide entry Co-authored-by: Jonas Bushart <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new optional module to house the code.
Add a new
CharacterSettrait, which is used to encode the differentcharacter sets with multiple unique types.
Add a basic test.
Missing:
Closes #350