Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Compose V2 #216

Merged
merged 1 commit into from
May 22, 2023
Merged

Migrate to Compose V2 #216

merged 1 commit into from
May 22, 2023

Conversation

JorickPepin
Copy link
Member

Fix #210

As written in the doc:

In Compose V1, an underscore (_) was used as the word separator. In Compose V2, a hyphen (-) is used as the word separator.

To keep compatibility with docker-compose, we could also use the --compatibility flag to continue generating names with (_) but Docker recommends to use this only as a temporary solution

lyrixx
lyrixx approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

pyrech
pyrech approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pyrech pyrech merged commit 6767350 into main May 22, 2023
@pyrech pyrech deleted the compose-v2 branch May 22, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for Docker Compose v2
3 participants
@JorickPepin @lyrixx @pyrech