Switch to more semantic exception classes #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES
Exception\BadRuleSetException
is now extend theInvalidArgumentException
.Exception\BadFixerConfigurationException
is now extend theLogicException
.EXPLANATION
BadRuleSetException
exception in many situations where for ex the passed rules array is empty or contains wrong rules, or when passing an invalid fixer instance, for all those situations I see theInvalidArgumentException
class is more semantic.BadFixerConfigurationException
, this exception is thrown if an invalid local config was passed with the constructor of the fixer, this should lead to a direct fix in the code and changed the passed local to valid one, so I think here extendingInvalidArgumentException
is more semantic and appropriate.