Build a .phar version #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
force-pushed
the
phar-version
branch
2 times, most recently
from
0351c5a to
a6d46cf
Compare
lyrixx
reviewed
Aug 30, 2021
welcoMattic
force-pushed
the
phar-version
branch
from
5aca1d4 to
8818a0d
Compare
lyrixx
reviewed
Aug 30, 2021
| if (is_dir($path)) { | ||
| $finder = new Finder(); | ||
|
|
||
| foreach ($finder->path($path)->depth($depth)->files() as $file) { |
There was a problem hiding this comment.
This does not work
- missing call to
in()methods - the depth is missleading: it required file to be at an exact depth of 1 :/ so if you give a dir by default file a depth = 0 are not processed.
|
superseeded by #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #54
This PR brings a standalone version of JoliTypo, packaged in a .phar file