Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #891, This PR is listing the modules directly from the filesystem.
According to this thread #1905, PyInstaller is not supporting the
pkgutil.iter_modules
so the dynamic module loading is not working.I have added a code to list the modules directly from the source code that needs to be included in the bundle for this to work.
It is using a small PyInstaller hook to fetch the providers source files:
If this PR will be approved, I will submit a PR in PyInstaller to include this hook.
It is not working for me using cx_freeze, I have no experience with it and I could not get it to work, always give me an exception:
From a small test, it seems that
pkgutil.iter_modules
is working in cx_freeze but I still got this error (even when I try to explicitly include the module).I think that it will be better to find a generic way for all the "code freezers" work but not sure that it is possible.