Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1352 Missing tests in various address providers #1616

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Fixes #1352 Missing tests in various address providers #1616

merged 5 commits into from
Feb 17, 2022

Conversation

Kalbra
Copy link
Contributor

@Kalbra Kalbra commented Feb 12, 2022

The following changes were made see #1352:

  • en_NZ: Adding tests
  • fil_PH: Already implemented
  • fr_CH: Adding tests
  • hu_HU: Adding tests
  • id_ID: Adding tests
  • it_IT: Adding more tests
  • ka_GE: Adding tests
  • ko_KR: Adding more tests
  • sk_SK: Already implemented
  • sl_SI: Adding tests
  • sv_SE: Adding tests
  • tl_PH: Already implemented
  • uk_UA: Adding tests

fcurella
fcurella requested changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you fix the linting issues?

@Kalbra
Copy link
Contributor Author

Kalbra commented Feb 14, 2022 •
edited
Loading

I reformated the files by using black --line-length 120 like discribed in the style guide.
I also deleted double TestEnNz and TestHuHu classes.

@Kalbra Kalbra requested a review from fcurella February 14, 2022 19:21
fcurella
fcurella requested changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running make lint will run black and isort with the correct settings.

There are also a couple of unused imports. Could you remove them?

@Kalbra
Copy link
Contributor Author

Kalbra commented Feb 16, 2022

I added formating using make lint

@Kalbra Kalbra requested a review from fcurella February 16, 2022 18:01
@fcurella
Copy link
Collaborator

Thank you!

@fcurella fcurella merged commit 3515ea9 into joke2k:master Feb 17, 2022
@Kalbra Kalbra deleted the test-for-address branch February 17, 2022 17:41
fcurella pushed a commit to epetrovski/faker that referenced this pull request Mar 7, 2022
@Kalbra @fcurella
Fixes joke2k#1352 Missing tests in various address providers (joke2k#…
3b797ae 
…1616)

* Adding more tests to address providers

* Fixing two small code mistakes which caused failure

* Reformation by black and deleting double tests

* Running make lint for formatting

* Deleting unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella Awaiting requested review from fcurella

Assignees
No one assigned
Labels
waiting on feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kalbra @fcurella