Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security_for_seed_phrase_request #874

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

khadar1020
Copy link

issue: #872
I have already kept the video how it is going to work.
@theborakompanioni can you please review my PR

Thank you

@khadar1020
Copy link
Author

khadar1020 commented Jan 5, 2025

Hi, @theborakompanioni can you please review my PR

@theborakompanioni
Copy link
Collaborator

Hi, @theborakompanioni can you please review my PR

Sorry, I have not had the time yet. Still traveling and only partially able to code - will review as soon as I am back on my workstation.

@theborakompanioni
Copy link
Collaborator

Hey @khadar1020!

Can we only ever have one modal shown, i.e. not overlapping?
Also, I am unsure about the approach calling postWalletUnlock, when the wallet is already unlocked, since it returns ApiAuthContext and it probably need handling.

@editwentyone
Copy link

lgtm. maybe also something like this above the input:

Enter Wallet password to unlock
[Password]
Unlock (button)

nice

@khadar1020
Copy link
Author

Ok when we click on the show seed phrase it will directly ask for wallet password and when the user enters the correct password then we should show them the seed phrase I think this is the best approach for ever showing the one model @theborakompanioni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants