Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev(regtest): update bitcoin core to v26 #710

Merged
merged 1 commit into from
Dec 20, 2023
Merged

dev(regtest): update bitcoin core to v26 #710

merged 1 commit into from
Dec 20, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Dec 13, 2023 •
edited
Loading

This updates regtest Bitcoin Core from v25 to v26.

Should serve as a reminder for everyone using JM/Jam wanting to upgrade to Bitcoin Core v26: You need to add arg -deprecatedrpc=create_bdb (at start or in conf file).

See JoinMarket-Org/joinmarket-clientserver#1571 for more information.

Meta question: How will this work for users with Umbrel/Citadel/RaspiBlitz/etc.?

@theborakompanioni theborakompanioni self-assigned this Dec 13, 2023
@theborakompanioni theborakompanioni added question Further information is requested dependencies Pull requests that update a dependency file devtools Improvements in tooling labels Dec 13, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review December 13, 2023 18:07
@kristapsk
Copy link
Contributor

Meta question: How will this work for users with Umbrel/Citadel/RaspiBlitz/etc.?

They should add deprecatedrpc=create_bdb for now. People using these should review / add comments and make sure it gets added to config when upgrading to v26. Probably JM will have proper descriptor wallet support on next release, but not sure how fast we will get there.

kristapsk
kristapsk approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK db73b4e

@theborakompanioni theborakompanioni merged commit d4466a0 into master Dec 20, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the dev/bitcoin-v26 branch December 20, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapsk kristapsk kristapsk approved these changes

Assignees

@theborakompanioni theborakompanioni

Labels
dependencies Pull requests that update a dependency file devtools Improvements in tooling question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @kristapsk