-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: improve balance spacing, coloring and grouping #691
Conversation
👏 awesome, thanks for the fast development next logical step is to get rid of "Display amounts in sats" under settings and thus we also don't need the kebab sats logo anymore/ anywhere. what do you think? do you like it? |
Yeah, however, let's ask users first if they even use the option to display amounts in sats. Currently, we also have all input fields representing amounts in sats, not in BTC. At least we should discuss this in a separate, dedicated ticket. Okay for you?
I really like the visual representation, yes. I do not like the current implementation as it uses |
31cfff0
to
02820bc
Compare
Newest commit styles the amount with css only. I'd say, that is "good enough" - at least better than before. Would you check again if it satisfies your expectations @editwentyone? Colors can be still be adapted, of course! Please check both, dark and light mode! Thanks 🙏 |
Yo, @editwentyone, this is now ready for review again. One remark: Instead of color |
lets do: |
This also feels rather unfavorable visually. Too little contrast, imho, don't you think? What about all the people with color weakness, like me? 😬 |
ok how about |
Resolves #690.
Styles the "insignificant" digits of the balance component making the value more readable and easy on the eyes.
📸 Before/After