Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: improve balance spacing, coloring and grouping #691

Merged
merged 13 commits into from
Nov 13, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Nov 4, 2023

Resolves #690.

Styles the "insignificant" digits of the balance component making the value more readable and easy on the eyes.

📸 Before/After

@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Nov 4, 2023
@theborakompanioni theborakompanioni self-assigned this Nov 4, 2023
@editwentyone
Copy link

👏 awesome, thanks for the fast development

next logical step is to get rid of "Display amounts in sats" under settings and thus we also don't need the kebab sats logo anymore/ anywhere.

what do you think? do you like it?

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Nov 6, 2023

👏 awesome, thanks for the fast development

next logical step is to get rid of "Display amounts in sats" under settings and thus we also don't need the kebab sats logo anymore/ anywhere.

Yeah, however, let's ask users first if they even use the option to display amounts in sats. Currently, we also have all input fields representing amounts in sats, not in BTC. At least we should discuss this in a separate, dedicated ticket. Okay for you?

what do you think? do you like it?

I really like the visual representation, yes. I do not like the current implementation as it uses opacity instead of the more accurate mix-blend-mode.. I did not get good results with mix-blend-mode yet - but will keep trying to improve it.

@theborakompanioni theborakompanioni force-pushed the ui/balance-spacing-and-coloring branch from 31cfff0 to 02820bc Compare November 6, 2023 19:19
@theborakompanioni
Copy link
Collaborator Author

Newest commit styles the amount with css only. I'd say, that is "good enough" - at least better than before. Would you check again if it satisfies your expectations @editwentyone? Colors can be still be adapted, of course! Please check both, dark and light mode! Thanks 🙏

@theborakompanioni theborakompanioni marked this pull request as ready for review November 6, 2023 19:21
@theborakompanioni theborakompanioni marked this pull request as draft November 7, 2023 08:44
@theborakompanioni
Copy link
Collaborator Author

Yo, @editwentyone, this is now ready for review again.

One remark: Instead of color #536475 it uses #212529 in light mode for highlighted balance digits. Otherwise it's quite hard to distinguish from de-emphasized digits.

@theborakompanioni theborakompanioni marked this pull request as ready for review November 10, 2023 09:28
@editwentyone
Copy link

editwentyone commented Nov 10, 2023

Yo, @editwentyone, this is now ready for review again.

One remark: Instead of color #536475 it uses #212529 in light mode for highlighted balance digits. Otherwise it's quite hard to distinguish from de-emphasized digits.

lets do: #344353 instead of #212529 if its ok for you

@theborakompanioni
Copy link
Collaborator Author

lets do: #344353 instead of #212529 if its ok for you

This also feels rather unfavorable visually. Too little contrast, imho, don't you think? What about all the people with color weakness, like me? 😬

@editwentyone
Copy link

editwentyone commented Nov 11, 2023

ok how about #0B3A69?

@theborakompanioni
Copy link
Collaborator Author

ok how about #0B3A69?

This is quite bluish.. but contrast ist good, imho.
Should it be applied? 🤔

image

@theborakompanioni theborakompanioni merged commit 821b227 into master Nov 13, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the ui/balance-spacing-and-coloring branch November 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance Component - Spacing, Coloring and Grouping
2 participants