feat: human readable locktime duration for fidelity bonds #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2022 18:49
ghost
requested a review
from 
|
cc @ABHISHEK-PANDEY2 ☝️ |
ghost
changed the title
Co-authored-by: Thebora Kompanioni <[email protected]>
Co-authored-by: Thebora Kompanioni <[email protected]>
Co-authored-by: Thebora Kompanioni <[email protected]>
Co-authored-by: Thebora Kompanioni <[email protected]>
|
Nice! Only thing missing is passing the Something like: const { i18n } = useTranslation()
[...]
fb.time.humanReadableDuration({ [...], locale: i18n.resolvedLanguage || i18n.language })But maybe there is a better way? |
…-webui into fb-time-util
Co-authored-by: Thebora Kompanioni <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397.
Mostly used existing code from the old fidelity bond branch. 👴
Moved out the time interval computation to an extra function but I don't really like it anymore since it gets super long at the call site.Also added a small addition to make sure to loop over the time units in the correct order, since it's not so clear if looping overObject.keys()always guarantees the order. So I figured manually sorting wouldn't hurt.The tests are the same as on the old branch. I hope it works like this
--might refactor thefb.timeAPI tomorrow to make callsites a bit cleaner. 🧹📸