Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new base attribute 'coordinates' to driver classes #289

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

johntruckenbrodt
Copy link
Owner

This new attribute is required for all driver classes and is for example used by method geometry.
A new test ensures that this method can be called for the following cases:

  • ASAR in ESA format (class ESA)
  • ERS1 in ESA format (class ESA)
  • ERS1 in CEOS format (class CEOS_ERS)
  • PSR2 in CEOS format (class CEOS_PSR)
  • S1 in SAFE format (class SAFE)

This required rewriting parts of the classes ESA and CEOS_ERS to remove calls to gdalinfo and instead directly read the metadata from the files. gdalinfo also reads the binary image data, which made it imposible to only add the metadata header/file to the repository for unit tests.
As a nice side effect, initializing a driver object is faster (although not as much as for SAFE data).

@johntruckenbrodt johntruckenbrodt merged commit cf4efaf into main Jan 10, 2024
2 checks passed
@johntruckenbrodt johntruckenbrodt deleted the feature/geometry_test branch January 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant