Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt ExamineGamma for different installs #268

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

MarkusZehner
Copy link
Contributor

This is a current fix for me, but the home directory of GAMMA might be different on other machines as well:
trying to get the version expects the pattern GAMMA_SOFTWARE-, which did not match the path on my install (/apps/GAMMA_SOFTWARE/VERSION), so the call returned an error when calling GAMMA functions via pyroSAR.
Maybe a hint could be added to a how to install with GAMMA if the home directory differs from this expected pattern.

This is a current fix for me, but the Installing of GAMMA might be different on other machines as well:

trying to get the version with the call in line 396 with GAMMA_SOFTWARE-<VERSION> was in conflict as the path on my end is /apps/GAMMA_SOFTWARE/VERSION

So the call returned an error and GAMMA was not usable
Copy link
Owner

@johntruckenbrodt johntruckenbrodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MarkusZehner. Can you please make this change?

pyroSAR/examine.py Outdated Show resolved Hide resolved
@johntruckenbrodt
Copy link
Owner

Looks good. Thanks a lot @MarkusZehner.

@johntruckenbrodt johntruckenbrodt merged commit 046a07a into johntruckenbrodt:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants