Updates to instructions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccabe
reviewed
Aug 10, 2017
| ``` | ||
| $ curl -SL https://raw.githubusercontent.com/johnmccabe/faas-img2ansi/master/images/gopher.png > gopher.png | ||
|
|
||
| $ curl localhost:8080/function/img2ansi --data-binary @gopher.png |
There was a problem hiding this comment.
the gopher image is in the images dir, if you want to dump the curl and set the @gopher to @images\gopher
There was a problem hiding this comment.
But you don't have to clone this repo to deploy the function/image. That was my thinking.
johnmccabe
reviewed
Aug 10, 2017
|
|
||
| ``` | ||
| # faas-cli -action deploy -image=johnmccabe/faas-img2ansi -name=img2ansi -fprocess="/usr/bin/faas-img2ansi" | ||
| 200 OK | ||
| URL: http://localhost:8080/function/img2ansi | ||
| ``` | ||
|
|
||
| ### Testing the Function |
|
@alexellis thanks for the feedback !!!! |
|
Apologies for the mergeup conflict, I'd tweaked some stuff on my phone and didn't notice the PR. |
|
I don't need to show up as a contributor.. but if you can implement the ideas that would be fine too. |
|
No worries, I've pushed the rebase to you branch and am 👍 to |
, thanks for the input !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included FaaS deployment instuctions
Includes instructions for installing CLI
Shows one option for installing/testing first, then gives others afterwards if people want the choice.
Uses curl to download your gopher image as a test image.