Skip to content

Commit

Permalink
fix: attach stderr to jupyter process
Browse files Browse the repository at this point in the history
Without stderr, kernels fail to start and JupyniumStartSync times out.

fixes kiyoon#97
  • Loading branch information
joh committed Oct 2, 2023
1 parent b02c65e commit 41e4d97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/jupynium/cmds/jupynium.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def fallback_open_notebook_server(
jupyter_stdout = tempfile.NamedTemporaryFile()
logger.info(f"Writing Jupyter Notebook server log to: {jupyter_stdout.name}")
notebook_proc = subprocess.Popen(
jupyter_command + notebook_args, stdout=jupyter_stdout
jupyter_command + notebook_args, stdout=jupyter_stdout, stderr=subprocess.STDOUT,
)
except FileNotFoundError:
# Command doesn't exist
Expand Down

0 comments on commit 41e4d97

Please sign in to comment.