Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement javaEnums extension #1041

Conversation

ddcruver
Copy link
Contributor

@ddcruver ddcruver commented Nov 6, 2019

Implement javaEnums extension to extend on what javaEnumNames provided.

@ddcruver ddcruver changed the title #1035 Implement javaEnums extension Implement javaEnums extension Nov 6, 2019
@ddcruver ddcruver mentioned this pull request Nov 6, 2019
@ddcruver
Copy link
Contributor Author

ddcruver commented Nov 8, 2019

@joelittlejohn I have additionally changed some of the methods to protected to allow a custom EnumRule to be able to extend the rule in multiple different discrete ways instead of copy-n-pasting or reimplementing it all.

For example in a custom EnumRule I would like to write for my project I would like to even override the Constructor that is generated and add additional fields to the enum. The actual use case is obscure so I am implementing it outside of this project.

@ddcruver
Copy link
Contributor Author

@joelittlejohn can we get this pull request in?

@joelittlejohn joelittlejohn added this to the 1.0.2 milestone Jan 10, 2020
@joelittlejohn joelittlejohn merged commit 81f900a into joelittlejohn:master Jan 10, 2020
@joelittlejohn
Copy link
Owner

If you could add something to https://github.com/joelittlejohn/jsonschema2pojo/wiki/Reference#extensions that would be great 👍

@ddcruver
Copy link
Contributor Author

I will put it on my todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants