Changed the the `entity_type` kwarg to `table_name` #111 and `register_entity` now throws exception if user hasn't passed `table_name` #91 #112

kousikmitra · 2019-12-05T16:20:44Z

#111

Changed the the entity_type kwarg to table_name
Added Deprecation warning for the entity_type kwargs

#91

Added test function to test whether register_entity throws an exception on not passing the table_name key
Added code to throw KeyError exception in register_entity function of FlaskJWTRouter class if user doesn't pass a table_name

…n not passing entity_type argument

…_type parameter

…n on not passing 'entity_type' argument joegasewicz#91

…tity_type' parameter joegasewicz#91

codecov · 2019-12-05T16:34:58Z

Codecov Report

Merging #112 into master will decrease coverage by 0.87%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   88.93%   88.05%   -0.88%     
==========================================
  Files           7        7              
  Lines         262      268       +6     
  Branches       29       31       +2     
==========================================
+ Hits          233      236       +3     
- Misses         23       25       +2     
- Partials        6        7       +1

Impacted Files	Coverage Δ
flask_jwt_router/_jwt_routes.py	`100% <ø> (ø)`	⬆️
flask_jwt_router/_authentication.py	`90.9% <100%> (ø)`	⬆️
flask_jwt_router/_entity.py	`76.78% <100%> (ø)`	⬆️
flask_jwt_router/_jwt_router.py	`89.47% <58.33%> (-4.65%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3b04f...2a7519c. Read the comment docs.

CHANGELOG.md

flask_jwt_router/_jwt_router.py

tests/test_jwt_router.py

joegasewicz · 2019-12-06T11:57:15Z

Nice work @kousikmitra, thank you.

joegasewicz · 2019-12-06T11:59:30Z

The API is now looking much better already, thanks

kousikmitra · 2019-12-06T12:04:45Z

@joegasewicz Thanks. Can you please take a look what is the issue with Codacy?

joegasewicz · 2019-12-06T12:05:56Z

@joegasewicz Thanks. Can you please take a look what is the issue with Codacy?

joegasewicz · 2019-12-06T12:08:31Z

@kousikmitra can you run make html to update the docs, also can you update the README.md contributors instructions with this info also, thank you.

kousikmitra · 2019-12-06T12:14:04Z

@kousikmitra can you run make html to update the docs, also can you update the README.md contributors instructions with this info also, thank you.

make html is giving this error.(I am running on windows)

process_begin: CreateProcess(NULL, sphinx-build -M html source build, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [Makefile:20: html] Error 2

Do I need any extra modules for this?

kousikmitra · 2019-12-06T12:17:16Z

@joegasewicz why is it showing get_entity_from_ext as invalid syntax?

joegasewicz · 2019-12-06T12:44:31Z

@kousikmitra can you run make html to update the docs, also can you update the README.md contributors instructions with this info also, thank you.

make html is giving this error.(I am running on windows)
process_begin: CreateProcess(NULL, sphinx-build -M html source build, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [Makefile:20: html] Error 2
Do I need any extra modules for this?

can you install Sphinx & ill update the Pipfile in my PR, thanks

joegasewicz · 2019-12-06T12:52:07Z

@joegasewicz why is it showing get_entity_from_ext as invalid syntax?

I have added your email to our codacy organization.

kousikmitra · 2019-12-06T12:56:00Z

@joegasewicz why is it showing get_entity_from_ext as invalid syntax?

I have added your email to our codacy organization.

How can I access this?

Edit: Can you please check what is the problem with CHANGELOG.md file?

joegasewicz · 2019-12-06T13:00:16Z

@joegasewicz why is it showing get_entity_from_ext as invalid syntax?

I have added your email to our codacy organization.

How can I access this?

https://app.codacy.com/manual/joegasewicz/Flask-JWT-Router/dashboard?bid=15313481

joegasewicz · 2019-12-06T13:08:00Z

Just this one now to fix, i ignored the inline docs on the abstract methods

joegasewicz · 2019-12-06T13:11:32Z

@kousikmitra let mew know when you have had enough and ill merge your PR in lol

joegasewicz · 2019-12-06T13:13:06Z

Sorry meant to comment and closed by mistake.

joegasewicz · 2019-12-06T13:14:12Z

@kousikmitra let me know when you're happy with the PR & ill merge in, thanks

kousikmitra · 2019-12-06T13:17:37Z

@kousikmitra let me know when you're happy with the PR & ill merge in, thanks

it's was checking fora tab and I was giving a space 💢 What to include in the README file?

joegasewicz · 2019-12-06T13:21:22Z

@kousikmitra let me know when you're happy with the PR & ill merge in, thanks

it's was checking fora tab and I was giving a space 💢 What to include in the README file?

Please add:

To update docs run:

make html

joegasewicz · 2019-12-06T13:29:31Z

Thanks @kousikmitra, great work!

kousikmitra added 7 commits December 5, 2019 21:37

Added test function to test whether egister_entity raises Exception o…

b07102c

…n not passing entity_type argument

added code in egister_entity to raise Exception on not passing entity…

9f99297

…_type parameter

Added test function to test whether 'register_entity' raises Exceptio…

af72be8

…n on not passing 'entity_type' argument joegasewicz#91

added code in 'register_entity' to raise Exception on not passing 'en…

544bb56

…tity_type' parameter joegasewicz#91

added code in 'register_entity' to raise Exception on not passing 'en…

f1af862

…tity_type' parameter joegasewicz#91

Merge branch 'master' of https://github.com/kousikmitra/Flask-JWT-Router

4980848

Merge branch 'master' into master

df18129

Changed the the entity_type kwarg to table_name joegasewicz#111

398fbaa

kousikmitra changed the title ~~register_entity now throw exception if user hasn't passed a entity_type #91~~ Changed the the entity_type kwarg to table_name #111 and register_entity now throws exception if user hasn't passed table_name #91 Dec 6, 2019

joegasewicz approved these changes Dec 6, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

flask_jwt_router/_jwt_router.py Show resolved Hide resolved

tests/test_jwt_router.py Show resolved Hide resolved

ps: a space can reduce your code coverage

e7608b2

joegasewicz approved these changes Dec 6, 2019

View reviewed changes

Fixed docstring for Sphinx build

f5ee1ee

Modified CHANGELOG. Removed Spaces for Codacy coverage

e3bc76d

Modified CHANGELOG

4cabe95

joegasewicz closed this Dec 6, 2019

joegasewicz reopened this Dec 6, 2019

Fixed CHANGELOG.md indentation

ead9989

joegasewicz approved these changes Dec 6, 2019

View reviewed changes

Updated README.md

2a7519c

joegasewicz approved these changes Dec 6, 2019

View reviewed changes

joegasewicz merged commit 60abd43 into joegasewicz:master Dec 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed the the `entity_type` kwarg to `table_name` #111 and `register_entity` now throws exception if user hasn't passed `table_name` #91 #112

Changed the the `entity_type` kwarg to `table_name` #111 and `register_entity` now throws exception if user hasn't passed `table_name` #91 #112

kousikmitra commented Dec 5, 2019 •

edited

Loading

codecov bot commented Dec 5, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019 •

edited

Loading

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

Changed the the entity_type kwarg to table_name #111 and register_entity now throws exception if user hasn't passed table_name #91 #112

Changed the the entity_type kwarg to table_name #111 and register_entity now throws exception if user hasn't passed table_name #91 #112

Conversation

kousikmitra commented Dec 5, 2019 • edited Loading

codecov bot commented Dec 5, 2019 • edited Loading

Codecov Report

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 • edited Loading

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019 • edited Loading

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 • edited Loading

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019 • edited Loading

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019 • edited Loading

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

kousikmitra commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

joegasewicz commented Dec 6, 2019

Changed the the `entity_type` kwarg to `table_name` #111 and `register_entity` now throws exception if user hasn't passed `table_name` #91 #112

Changed the the `entity_type` kwarg to `table_name` #111 and `register_entity` now throws exception if user hasn't passed `table_name` #91 #112

kousikmitra commented Dec 5, 2019 •

edited

Loading

codecov bot commented Dec 5, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019 •

edited

Loading

kousikmitra commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019 •

edited

Loading

kousikmitra commented Dec 6, 2019 •

edited

Loading

joegasewicz commented Dec 6, 2019 •

edited

Loading