magento#108: Clear Shopping Cart - Refactor to fix Static Tests faile…

…d result
joctabio · Jun 9, 2020 · 7dad27c · 7dad27c
1 parent 2c4ee78
commit 7dad27c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/app/code/Magento/Checkout/Block/Cart/Grid.php b/app/code/Magento/Checkout/Block/Cart/Grid.php
@@ -107,7 +107,8 @@ protected function _construct()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @since 100.2.0
      */
     protected function _prepareLayout()
@@ -151,7 +152,8 @@ public function getItemsForGrid()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @since 100.2.0
      */
     public function getItems()
@@ -187,7 +189,7 @@ private function isPagerDisplayedOnPage()
      */
     public function isClearShoppingCartEnabled()
     {
-        return (bool) $this->_scopeConfig->getValue(
+        return (bool)$this->_scopeConfig->getValue(
             self::XPATH_CONFIG_ENABLE_CLEAR_SHOPPING_CART,
             \Magento\Store\Model\ScopeInterface::SCOPE_STORE
         );

diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml
@@ -20,7 +20,7 @@
           class="form form-cart">
     <?= $block->getBlockHtml('formkey') ?>
     <div class="cart table-wrapper<?= $mergedCells == 2 ? ' detailed' : '' ?>">
-        <?php if ($block->getPagerHtml()) :?>
+        <?php if ($block->getPagerHtml()): ?>
             <div class="cart-products-toolbar cart-products-toolbar-top toolbar"
                  data-attribute="cart-products-toolbar-top"><?= $block->getPagerHtml() ?>
             </div>
@@ -38,25 +38,25 @@
                     <th class="col subtotal" scope="col"><span><?= $block->escapeHtml(__('Subtotal')) ?></span></th>
                 </tr>
             </thead>
-            <?php foreach ($block->getItems() as $_item) :?>
+            <?php foreach ($block->getItems() as $_item): ?>
                 <?= $block->getItemHtml($_item) ?>
             <?php endforeach ?>
         </table>
-        <?php if ($block->getPagerHtml()) :?>
+        <?php if ($block->getPagerHtml()): ?>
             <div class="cart-products-toolbar cart-products-toolbar-bottom toolbar"
                  data-attribute="cart-products-toolbar-bottom"><?= $block->getPagerHtml() ?>
             </div>
         <?php endif ?>
     </div>
     <div class="cart main actions">
-        <?php if ($block->getContinueShoppingUrl()) :?>
+        <?php if ($block->getContinueShoppingUrl()): ?>
             <a class="action continue"
                href="<?= $block->escapeUrl($block->getContinueShoppingUrl()) ?>"
                title="<?= $block->escapeHtml(__('Continue Shopping')) ?>">
                 <span><?= $block->escapeHtml(__('Continue Shopping')) ?></span>
             </a>
         <?php endif; ?>
-        <?php if ($block->isClearShoppingCartEnabled()) :?>
+        <?php if ($block->isClearShoppingCartEnabled()): ?>
             <button type="button"
                     name="update_cart_action"
                     data-cart-empty=""

diff --git a/app/code/Magento/Checkout/view/frontend/web/js/shopping-cart.js b/app/code/Magento/Checkout/view/frontend/web/js/shopping-cart.js
@@ -63,7 +63,7 @@ define([
          * Display confirmation modal for clearing the cart
          * @private
          */
-        _clearCartConfirmation: function() {
+        _clearCartConfirmation: function () {
             var self = this;
 
             confirm({
@@ -80,7 +80,7 @@ define([
          * Prepares the form and submit to clear the cart
          * @public
          */
-        clearCart: function() {
+        clearCart: function () {
             $(this.options.emptyCartButton).attr('name', 'update_cart_action_temp');
             $(this.options.updateCartActionContainer)
                 .attr('name', 'update_cart_action').attr('value', 'empty_cart');