Close #43: Fix tests and run in GitHub action

* README.md: updated for GitHub Actions badge
* .github/workflows/build-and-test.yml: Added workflow
* hunchensocket-tests.asd: Extracted from main .asd file to appease ASDF
* hunchensocket-tests.lisp: Fix test for binary messages without temp files
* hunchensocket.asd: Extracted test system
* run-tests.lisp: Test run script for CI

.github/workflows/build-and-test.yml

@@ -0,0 +1,36 @@
+name: 'Build and Test'
+on:
+  - workflow_dispatch
+  - push
+
+jobs:
+  install-quicklisp:
+    strategy:
+      matrix:
+        implementation: ['sbcl']
+        os: ['ubuntu-latest', 'macos-latest']
+    runs-on: '${{ matrix.os }}'
+    name: 'Install Common Lisp'
+    steps:
+      - uses: actions/checkout@v3
+      - name: 'Install MacPorts'
+        if: runner.os == 'macOS'
+        uses: melusina-org/setup-macports@v1
+
+      - uses: melusina-org/setup-common-lisp@v1
+        with:
+          implementation: '${{ matrix.implementation }}'
+
+      - uses: melusina-org/setup-quicklisp@v1
+        id: 'quicklisp'
+        with:
+          implementation: '${{ matrix.implementation }}'
+
+      - name: 'Validate installed implementation'
+        run: |
+          test -d '${{ steps.quicklisp.outputs.quicklisp-home }}'
+          test -d '${{ steps.quicklisp.outputs.quicklisp-local-projects }}'
+
+      - name: 'Run tests'
+        run: |
+          sbcl --load run-tests.lisp

README.md

@@ -1,4 +1,5 @@
-[![Build Status](https://travis-ci.org/joaotavora/hunchensocket.svg?branch=master)](https://travis-ci.org/joaotavora/hunchensocket)
+![build and test](https://github.com/joaotavora/hunchensocket/actions/workflows/build-and-test.yml/badge.svg)
+
 Hunchensocket - WebSockets for Hunchentoot
 ==========================================
 

hunchensocket-tests.asd

@@ -0,0 +1,9 @@
+(asdf:defsystem :hunchensocket-tests
+  :description "Tests for Hunchensocket"
+  :version #.(with-open-file (f "VERSION") (string (read f)))
+  :depends-on (:fiasco
+               :hunchensocket)
+  :serial t
+  :components
+  ((:file "hunchensocket-tests")))
+

hunchensocket-tests.lisp

@@ -83,21 +83,13 @@
       (push message received-messages))))
 
 (defmethod binary-message-received ((resource mock-resource)
-                                    (client mock-client) file)
+                                    (client mock-client) data)
   (is *expected-files*
       "Didn't expect a binary file at all but got one")
   (when *expected-files*
-    (let ((file-contents
-            (with-open-file (fstream file :direction :input
-                                          :element-type '(unsigned-byte 8))
-              (let ((seq (make-array (file-length fstream)
-                                     :element-type '(unsigned-byte 8)
-                                     :fill-pointer t)))
-                (setf (fill-pointer seq) (read-sequence seq fstream))
-                seq))))
-      (is (equalp (pop *expected-files*) file-contents))
-      (with-slots (received-files) client
-        (push file-contents received-files)))))
+    (is (equalp (pop *expected-files*) data))
+    (with-slots (received-files) client
+      (push data received-files))))
 
 (defmacro with-resource-and-client ((res-sym client-sym)
                                     (mock-input mock-output) &body body)
@@ -221,16 +213,3 @@
       (let ((*max-total-size* 2048)
             (*max-fragment-size* 128))
         (test-fragmented-binaries #x02 #x00 #x00 #x80)))))
-
-
-
-
-
-
-
-
-
-
-
-
-

hunchensocket.asd

@@ -18,13 +18,3 @@
   ((:file "package")
    (:file "hunchensocket")))
 
-(asdf:defsystem :hunchensocket-tests
-  :description "Tests for Hunchensocket"
-  :version #.(with-open-file (f "VERSION") (string (read f)))
-  :depends-on (:fiasco
-               :hunchensocket)
-  :serial t
-  :components
-  ((:file "hunchensocket-tests")))
-
-

run-tests.lisp

@@ -0,0 +1,10 @@
+;; -*- Lisp -*-
+
+(ql:quickload :hunchensocket-tests)
+(handler-case
+    (unless (fiasco:run-package-tests :package :hunchensocket-tests)
+      (error "test(s) failed"))
+  (error (e)
+    (format t ";; ~A~%" e)
+    (sb-ext:exit :code 1)))
+(sb-ext:exit :code 0)