Skip to content

Commit

Permalink
Fixup last commit
Browse files Browse the repository at this point in the history
Per #726.

I'm still not entirely convinced using all-completion here is a good
idea.  As usual the completion list we get from the server is
pre-filtered to whatever the server wishes.  Letting the completion
style do its own filtering (most completion styles use
completion-regexp-list and all-completions themselves) is completely
useless here.

Let's hope it's not harmful.

* eglot.el (eglot-completion-at-point): Fix all-completions call
  • Loading branch information
joaotavora committed Sep 5, 2021
1 parent 9b63f21 commit c17bdf6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions eglot.el
Original file line number Diff line number Diff line change
Expand Up @@ -2371,8 +2371,7 @@ is not active."
(filterText (plist-get item :filterText)))
(and (or (null pred) (funcall pred proxy))
(string-prefix-p
probe (or filterText proxy) completion-ignore-case))))
(funcall proxies)))))
probe (or filterText proxy) completion-ignore-case))))))))
:annotation-function
(lambda (proxy)
(eglot--dbind ((CompletionItem) detail kind)
Expand Down

0 comments on commit c17bdf6

Please sign in to comment.