Support for Inheritance #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes, key factory, adapter, lists, and references are all passed on to subclasses. Also added type attribute to help keep track in the database.
Feels like load should always return an instance.
Hate doing crap either of these ways but this seems to work on all rubies.
Doesn't like sending arg to block that doesn't have parameter. First check arity then pass model along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial support for inheritance. Copies over attributes, lists, references, adapter and key factory. Also adds a type attribute and correctly instantiates based on the type attribute.
I hate using type because nil.type gives you a warning instead of a no method error.
Tempted to call it constant or _type (like MM).