Add Dockerfile for Arch Linux & use a more complicated WORKDIR #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libclang on Fedora includes a relative header search path, which works by accident when we're using /src for testing. Break it.
Separate finding all the distros we have Dockerfiles for from generating the targets for auto-completion. We'll be needing the distro list later.
Make it easier to run everything across all the distros we have Dockerfiles for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dockerfile for running tests on Arch Linux (it's broken), and change WORKDIR to
/path/to/srcin all Dockerfiles (breaking Fedora docker testing in the process).Turns out libclang can't find headers on either Arch Linux or Fedora. And it only worked by accident with our Fedora Docker images, because libclang on Fedora has some relative paths that just worked with
/srcas the current dir. Seriously. 🤦With #263 soon coming to the rescue, and fixing all of this (tested), highlight all the breakage.