Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix make docker-test and docker-test-html targets #152

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Apr 3, 2023

Switching to src/ hierarchy broke the docker-test and docker-test-html targets, as the old docker setup specifically used the hawkmoth package from the source, using a mount, and the main point of the src/ hierarchy was to make this difficult.

Instead, archive the source and expand it in the container, using the same editable build method. It's not perfect, but it works.

Switching to src/ hierarchy broke the docker-test and docker-test-html
targets, as the old docker setup specifically used the hawkmoth package
from the source, using a mount, and the main point of the src/ hierarchy
was to make this difficult.

Instead, archive the source and expand it in the container, using the
same editable build method. It's not perfect, but it works.
@BrunoMSantos
Copy link
Collaborator

I confess I've used this maybe once to see that it worked and never again. If I remember correctly this was added due to some distros packaging an old version of Clang. Am I remembering it wrong? I assume it's still needed.

Anyway, code wise, looks good to me 👍

@jnikula jnikula merged commit 3ddfedf into master Apr 4, 2023
@jnikula
Copy link
Owner Author

jnikula commented Apr 4, 2023

I confess I've used this maybe once to see that it worked and never again. If I remember correctly this was added due to some distros packaging an old version of Clang. Am I remembering it wrong? I assume it's still needed.

I don't really use it, but doesn't seem too much trouble to keep it working, in case a need arises.

The other docker images that I upload to docker hub I've pretty much decided to discontinue. Doesn't look like anyone's really using them. I think I'll just stop and see if someone ever complains.

Anyway, code wise, looks good to me +1

Thanks, merged!

@jnikula jnikula deleted the docker-test branch April 4, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants