-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test updates #119
Test updates #119
Conversation
One of the strings using {domain} isn't an f-string.
Remove a couple of leftovers.
Make the directive explicit instead of having implicit 'autodoc'.
Hide how exactly we're deducing the filename.
Specify the filename explicitly instead of deriving it from the testcase name.
Specify the filename explicitly instead of deriving it from the testcase name.
Open code the needed parts.
Unify the signature with the other functions to get filenames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an easy review this one: it's good to go.
I would only add one more commit: now we could reuse most, if not all, the .rst files from the C cases for the C++ cases and maybe some of the .stderr ones.
It can be separate to the series though.
There aren't all that many exact dupes though. The domain is different. Unless we want to go for running format on the entire files, and have |
Ah, of course. Not a bad idea to support templating in expected results eventually though! |
A couple of fixes, and a bunch of changes to specify various files explicitly via the testcase yaml instead of deducing them from the filename. It's not quite enough to make it work for for subdirectories, but it's a good step in that direction.
@BrunoMSantos There's no rush with reviewing this one, I know you've got other priorities right now. More like FYI.