Support for dynamic mbeans. #130
Conversation
|
@cyrille-leclerc ptal |
|
@cyrille-leclerc ping? |
|
@johnou sorry for the late answer. Can you please add a test case and update the documentation on README.md? |
johnou
force-pushed
the
support_dynamic
branch
2 times, most recently
from
486331c to
d13f33e
Compare
johnou
force-pushed
the
support_dynamic
branch
from
d13f33e to
9a8be43
Compare
|
@cyrille-leclerc np busy here too with Christmas campaigns, I have updated the pull request to include a test case and update the documentation. |
|
@johnou isn't your PR broader than attributes of DynamicMBean? Your PR seem to collect all the attributes if no attribute has been specified. Am I right? |
|
@cyrille-leclerc that's correct, I think the primary use-case would be dynamicmbeans but it's also handy for when you do not want to define all attributes yet still collect everything. |
|
@cyrille-leclerc ok to pull this in? |
|
@cyrille-leclerc we've been running this in prod for almost three years now without problems 👍 would you kindly pull this in and take a look at #133 |
|
Sorry for the delay. Merged. |
|
Thanks @johnou . Can you please test https://github.com/jmxtrans/embedded-jmxtrans/releases/tag/embedded-jmxtrans-1.2.2-beta-1 |
soon as Matti is back from holidays he will check it out 👍 |
Currently for every query definition every attribute must be defined, unfortunately this does not play well with dynamic mbeans.