Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #308 #458

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Fix Issue #308 #458

merged 2 commits into from
Oct 27, 2020

Conversation

pangyikhei
Copy link
Contributor

Fixes issue #308 by checking if there is a value for the L case.

Added a before_last_day_of_month resource string.

@pangyikhei
Copy link
Contributor Author

I used Google Translate to translate "before the last day of the month".
Technically the word order in Chinese when combined with "X days" is grammatically incorrect (the days should come after).
I'm not sure about the other non-English languages.

Actually, I'm thinking I should create multiple resource strings so the grammar is better than using English as a reference when building the string.

@pangyikhei
Copy link
Contributor Author

Replaced before_last_day_of_month with two resource strings: day_before_last_day_of_month and days_before_last_day_of_month so it is possibly more grammatically correct in more languages.

@jmrozanec
Copy link
Owner

jmrozanec commented Oct 27, 2020

@pangyikhei merged! Thank you for contributing to cron-utils! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants