A cron-utils bug by week

[HongZhaoHua]

use cron "0 0 12 ? * SUN#4 2020"

and use dateTime = ZonedDateTime.of(2021, 1, 1, 0, 0, 0, ZoneOffset.UTC);

now, run execution.lastExecution(dateTime);

you will get the result is 2022-11-27T12:00

but in fact, the result must be 2020-12-27T12:00

[jmrozanec]

@HongZhaoHua thank you for reporting this. May we ask you a PR with a test? Thanks!

[HongZhaoHua]

@jmrozanec sure.

here is the test, plz check it.

@Test
public void test() {
    CronDefinition cronDefinition = CronDefinitionBuilder.instanceDefinitionFor(CronType.QUARTZ);
    CronParser parser = new CronParser(cronDefinition);
    ExecutionTime execution = ExecutionTime.forCron(parser.parse("0 0 12 ? * SUN#4 2020"));
    LocalDate date = LocalDate.of(2021, 1, 1);
    LocalTime time = LocalTime.of(0, 0, 0);
    ZonedDateTime dateTime = ZonedDateTime.of(date, time, ZoneOffset.UTC);
    for (int index = 0, size = 12; index < size; index++) {
        dateTime = execution.lastExecution(dateTime).orElse(null);
        Assert.assertEquals(LocalDateTime.of(2020, 12 - index, 1, 12, 0, 0).with(TemporalAdjusters.dayOfWeekInMonth(4, DayOfWeek.SUNDAY)), dateTime.toLocalDateTime());
    }
}

[jmrozanec]

@HongZhaoHua thanks! 😄

[HongZhaoHua]

@jmrozanec u r welcome.
^^

[jmrozanec]

@HongZhaoHua the issue is now fixed!