Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for "wasm-function" symbol maps #93

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

evanw
Copy link
Contributor

@evanw evanw commented Jul 18, 2018

This is an improvement to #76, which added support for asm.js symbol maps. This PR expands this to also work for emscripten's WebAssembly symbol maps too. This currently only works in Firefox. Chrome would need to fix https://crbug.com/863205 for this to be useful in Chrome.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 38.959% when pulling e1e07f2 on evanw:wasm-function into 8fcc0f8 on jlfwong:master.

Copy link
Owner

@jlfwong jlfwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet - thanks! Pulled down locally and verified it works.

@jlfwong jlfwong merged commit 1b36a2e into jlfwong:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants