Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit to multiple problems at once #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hweetty
Copy link

@hweetty hweetty commented Sep 14, 2014

For some assignments, there are many parts to a single question but each file must be submitted on its own.

This feature will automatically submit files to matching problems.

marmoset screenie

@@ -88,17 +88,35 @@ class MarmosetClient
problem_links = {}

@course_page.links.find_all{|l| l.href.include? 'submitProject.jsp'}.each do |view_link|

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the added whitespace?

@jlfwong
Copy link
Owner

jlfwong commented Sep 15, 2014

Cool - I haven't touched this code in almost 4 years :) Thanks for the PR.

In my opinion, this is really surprising default behaviour. Instead of making filename not required, I'd much rather see a new flag called --submit-all or something along those lines that does this automatic pattern matching magic business.

@hweetty
Copy link
Author

hweetty commented Sep 15, 2014

Thanks for creating this tool in the first place. What's amazing is that the Marmoset submission system is still being used :p

I get that it would be more consistent to add a new flag for multiple submissions. However explicitly not typing in the problem id and filename would signify that the user doesn't just want to submit to a single problem. As far as I know Marmoset doesn't have any penalties against too many submissions, so it is not a risky thing to submit multiple projects by accident.

I'm still making some changes so let me know if there are any other changes you want to discuss.

@jlfwong
Copy link
Owner

jlfwong commented Sep 15, 2014

explicitly not typing in the problem id and filename would signify that the user doesn't just want to submit to a single problem.

"Explicitly not" is implicit :P

I think it's pretty likely that someone would do it by accident. I forget to provide flags all the time, or accidentally hit enter early when typing commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants