Move VXYZ and EToV into a VertexMappedMesh mesh type
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pre-0.15 #70 +/- ##
===========================================
Coverage ? 96.76%
===========================================
Files ? 20
Lines ? 2258
Branches ? 0
===========================================
Hits ? 2185
Misses ? 73
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jlchan
added a commit
that referenced
this pull request
Jan 10, 2023
* Replacing `ComponentArrays` with `NamedArrayPartition` (#66) * adding NamedArrayPartition type * adding broadcast precedence * removing ComponentArrays from cut-cell * adding Hendrik to acknowledgments * Removing ComponentArrays from SRD * removing all ComponentArrays * more tests * fix test * using FillArrays to save memory * add tests * comment out some unused code * more tests * update docs * deleting `Nplot` in `RefElemData` (#67) * removing Nplot and deprecating old constructor * adding tests back * adding `pre-0.15` branch to ci * Relaxing restriction on `MeshData.Drst` type parameter (#68) * add NEWS.md * inferring RefElemData dimension from ElemShape * accounting for new AbstractElemShape{NDIMS} parameter * adding NDIMS parameter to PhysicalFrame element type * update compat bounds * Update NEWS.md * add more NamedArrayPartition specializations * update news * add deprecation * Revert "add deprecation" This reverts commit 1528fb1. * Revert "update news" This reverts commit 7e48bbd. * removing finished TODOs * remove finished TODO * Move `VXYZ` and `EToV` into a `VertexMappedMesh` mesh type (#70) * adding VertexMappedMesh to MeshData * moving VXYZ, EToV into hybrid mesh types * moving VXYZ, EToV into cut cell mesh type * moving VXYZ, EToV into noncon mesh type * remove outdated comment * remove macro for _getproperty, use function with inlining * update docs * update news * add deprecation * cleanup comments * comments * misc formatting * Add `CurvedMesh` type (#72) * adding CurvedMesh type * updating NEWS.md * removing deprecated constructor * rename docs and add more mesh docs * add precomputed cut cell operators * update news * add TODO * Update NEWS.md * Update NEWS.md * update news add TODO * Update NEWS.md Update NEWS.md * Update NEWS.md * specializing getproperty for MeshData{NDIMS, <:HybridMesh} too * reorganize compute_normals, improve comments * fix capitalization * fix potential bug with r1D, w1D being undefined * bump version * bump test/Project.toml version * more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
VXYZandEToVfields fromMeshDataand refactors them into aVertexMappedMeshmesh type. TheHybridMeshandNonConformingMeshtypes have similarly been updated. This avoids having "dummy" fields for cut cell meshes, and should also allow us to dispatch onMeshData{NDIMS, MeshType}and distinguish between, for example, vertex-mapped meshes and curved HOHQmesh.jl meshes.