Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Davknapp this is the draft I have for a tensor product wedge. The setup only involves changing the reference element constructor; everything else should remain the same. Here's an example of how I call it
Trixi.jl specializes
RefElemData
for FDSBP types usingDerivativeOperators
from @ranocha's SummationByPartsOperators.jl package (see https://github.com/trixi-framework/Trixi.jl/blob/6e5512e8f4b8b2c3bf6811c6a3b0e548de4a91f6/src/solvers/dgmulti/sbp.jl#L66-L120). The intent is to use these with theTensorProductWedge
type to construct discretization matrices.There are two major changes needed for this PR:
mul!
MichielStock/Kronecker.jl#109).RefElemData
currently assumes all differentiation matrices are the same type; however, it might make sense to allow the tensor product wedge to have differentiation matrices of different type (e.g., a sparse differentiation matrix in the vertical direction). This would be a breaking change v0.15 updates #58.