Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in post scriptum parser y_offset #50

Open
tsc25 opened this issue Nov 27, 2022 · 0 comments
Open

Bug in post scriptum parser y_offset #50

tsc25 opened this issue Nov 27, 2022 · 0 comments

Comments

@tsc25
Copy link

tsc25 commented Nov 27, 2022

Line 4564 of synctex_parser.c (towards end of _synctex_scan_post_scriptum function) should read:

    scanner->y_offset = fs.value;

instead of x_offset.

Because scanner->y_offset and scanner->y_offset are initialised to the bogus value 6.027e23, setting any X or Y offset in the post scriptum leads to synctex applying a y_offset of 6.027e23. So this bug breaks the post scriptum offset override feature, leading to bogus output from synctex view/edit if any offset is set.

jlaurens added a commit that referenced this issue Dec 10, 2022
Update synctex_parser.c
aminophen added a commit to TeX-Live/texlive-source that referenced this issue Jan 8, 2023
  * Changed files (on https://github.com/jlaurens/synctex):
    synctex_parser.c
    synctex_parser_readme.md
    synctex_parser_utils.c

  - Fix compilation with clang with -Wformat-nonliteral.
    jlaurens/synctex#38
  - Fix build when compiling with -Werror=implicit-function-declaration.
    jlaurens/synctex#39
  - More explanations.
  - Remove recursion form _synctex_free_handle_old.
  - Fix a Bug in post scriptum parser y_offset.
    jlaurens/synctex#50

The following issue is not resolved:

  - Fix a Memory leak when opening files.
    jlaurens/synctex#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant