Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zlib library name (again) #40

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Fix zlib library name (again) #40

merged 2 commits into from
Jan 27, 2024

Conversation

pema99
Copy link
Contributor

@pema99 pema99 commented Jan 24, 2024

As discussed

#38 (comment)

@jkvargas
Copy link
Owner

hey man,
thanks for your contribution.
So, before I can merge your fix, we need to have all the steps passing =)

@pema99
Copy link
Contributor Author

pema99 commented Jan 26, 2024

Hmm. Maybe you were right about the linux issue? I double checked the name of the library in the linux zip file, and it is indeed "libzlibstatic.a", but I guess the linker on linux might be adding the "static" part automatically or something? I'm not really familiar enough with linux to know, but I can try guarding based on the platform, second.

@pema99
Copy link
Contributor Author

pema99 commented Jan 26, 2024

Let's see if that does it

@jkvargas jkvargas merged commit 6af06ae into jkvargas:main Jan 27, 2024
8 checks passed
@jkvargas
Copy link
Owner

thanks, mate =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants