fixed selectEndpoints resets constraints properly #2640
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
saghul
reviewed
Feb 14, 2025
| if (constraints.selectedEndpoints && constraints.selectedEndpoints.length === 0) { | ||
| this._receiverVideoConstraints.selectedEndpoints = undefined; | ||
| } | ||
| this._rtc.setReceiverVideoConstraints(this._receiverVideoConstraints); |
There was a problem hiding this comment.
This line is duplicated below. You just need to call it once.
There was a problem hiding this comment.
Apologies, I didn’t realize I had the exact same line twice. Thank you for catching that!
saghul
approved these changes
Feb 15, 2025
|
thanks for the review and approval, @saghul I'll wait for @jallamsetty1's final approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2134
When calling selectEndpoints, previously selected participants were still present instead of being removed.
Modified setReceiverConstraints() in ReceiveVideoController.js
If selectedEndpoints is an empty array, it now resets the constraints properly instead of keeping old values.
this._receiverVideoConstraints.selectedEndpoints = undefined;
This ensures that when selectEndpoints is called
It completely resets selectedEndpoints instead of keeping old data.