fix(ResumeTask) reset resume timeout after running timer #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will avoid having an extra "Canceling connection resume task" log line every time we schedule a timer.
damencho
approved these changes
Aug 23, 2024
Romick2005
reviewed
Aug 30, 2024
| @@ -127,6 +127,8 @@ export default class ResumeTask { | |||
| * @returns {void} | |||
| */ | |||
| _resumeConnection() { | |||
| this._resumeTimeout = undefined; | |||
There was a problem hiding this comment.
Should you also clear timeout? Like: clearTimeout(this._resumeTimeout); or it is not necessary?
There was a problem hiding this comment.
Not necessary since this function is called in the timeout handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will avoid having an extra "Canceling connection resume task" log line every time we schedule a timer.