Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stats): Fix audio/video bitrate wrongly report as 0 due to ssrc b… #2431

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ruozhen-vsee
Copy link
Contributor

…itrate stats reset before being used.

Its due to
ssrcStats.resetBitrate()
being called before audio/video bitrate calculation

        if (track.isAudioTrack()) {
            audioBitrateDownload += ssrcStats.bitrate.download;
            audioBitrateUpload += ssrcStats.bitrate.upload;
            audioCodec = ssrcStats.codec;
        } else {
            videoBitrateDownload += ssrcStats.bitrate.download;
            videoBitrateUpload += ssrcStats.bitrate.upload;
            videoCodec = ssrcStats.codec;
        }

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul saghul requested a review from jallamsetty1 January 10, 2024 06:46
@jallamsetty1
Copy link
Member

Jenkins test this please.

@jallamsetty1
Copy link
Member

Good catch! Thanks for fixing it @ruozhen-vsee

@jallamsetty1 jallamsetty1 merged commit 899ea00 into jitsi:master Jan 10, 2024
2 checks passed
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
subhamcyara pushed a commit to subhamcyara/lib-jitsi-meet that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants