Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoctor::Converter:Base#handles? method always return false #5

Closed
ggrossetie opened this issue Dec 10, 2019 · 0 comments
Closed

Comments

@ggrossetie
Copy link
Contributor

Here's the implementation of the Asciidoctor::Converter:Base#handles method:

def handles? transform
  respond_to? %(convert_#{transform})
end

When using supports_templates, Asciidoctor will create a CompositeConverter that uses the handles method to find a converter for the specified "transform".
Since the methods are not prefixed by convert_ the handles? method will always returns false.

If we want to stay backward compatible with Asciidoctor 1.5.8, I think we should override the handles? method. Otherwise we should prefix the "convert" methods by convert_.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant