-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asciidoctor::Converter:Base#handles? method always return false #5
Comments
jirutka
pushed a commit
to ggrossetie/asciidoctor-templates-compiler
that referenced
this issue
Jan 21, 2020
jirutka
added a commit
to jirutka/asciidoctor-html5s
that referenced
this issue
Mar 12, 2020
jirutka
added a commit
that referenced
this issue
Aug 27, 2022
jirutka
added a commit
that referenced
this issue
Aug 27, 2022
jirutka
added a commit
that referenced
this issue
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's the implementation of the
Asciidoctor::Converter:Base#handles
method:When using
supports_templates
, Asciidoctor will create aCompositeConverter
that uses thehandles
method to find a converter for the specified "transform".Since the methods are not prefixed by
convert_
thehandles?
method will always returns false.If we want to stay backward compatible with Asciidoctor 1.5.8, I think we should override the
handles?
method. Otherwise we should prefix the "convert" methods byconvert_
.What do you think?
The text was updated successfully, but these errors were encountered: