Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small optimization in HTTP server and client #6183

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 23, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/client component/type area/testing This issue/PR affects testing labels Jul 23, 2024
@JoanFM JoanFM force-pushed the fix-set-direct-docs branch from b2c0ace to ef12539 Compare July 23, 2024 09:49
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.23%. Comparing base (e3ea29f) to head (d45860a).
Report is 8 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/worker/http_fastapi_app.py 0.00% 6 Missing ⚠️
jina/types/request/data.py 50.00% 4 Missing ⚠️
jina/serve/runtimes/worker/request_handling.py 62.50% 3 Missing ⚠️
jina/clients/mixin.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6183      +/-   ##
==========================================
- Coverage   54.92%   46.23%   -8.69%     
==========================================
  Files         150      150              
  Lines       14125    14141      +16     
==========================================
- Hits         7758     6538    -1220     
- Misses       6367     7603    +1236     
Flag Coverage Δ
jina 46.23% <44.00%> (-8.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the fix-set-direct-docs branch from ef12539 to d45860a Compare July 23, 2024 10:17
@JoanFM JoanFM changed the title fix: set direct docs fix: small optimization in HTTP server and client Jul 23, 2024
@JoanFM JoanFM merged commit 4eaeb2d into master Jul 23, 2024
129 of 131 checks passed
@JoanFM JoanFM deleted the fix-set-direct-docs branch July 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant