Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix head commit ahead base commit #2968

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jul 17, 2021

Using this action could check changed files for docstring/black without rebase/merge master back to feature brnach.

The head commit for this push event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.

@bwanglzu bwanglzu requested a review from hanxiao as a code owner July 17, 2021 11:08
@jina-bot jina-bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jul 17, 2021
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #2968 (9e9551c) into master (547d5d4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2968      +/-   ##
==========================================
- Coverage   90.02%   89.99%   -0.04%     
==========================================
  Files         138      138              
  Lines        9511     9511              
==========================================
- Hits         8562     8559       -3     
- Misses        949      952       +3     
Flag Coverage Δ
daemon 43.71% <ø> (-0.03%) ⬇️
jina 89.98% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 95.58% <0.00%> (-1.48%) ⬇️
jina/peapods/runtimes/jinad/client.py 90.53% <0.00%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547d5d4...9e9551c. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1843, delta to last 2 avg.: +1%
  • 😶 query QPS at 24, delta to last 2 avg.: -1%
  • 😶 dam extend QPS at 74454, delta to last 2 avg.: +0%
  • 😶 avg flow time within 1.6609 seconds, delta to last 2 avg.: +0%
  • 🐎🐎 import jina within 0.3341 seconds, delta to last 2 avg.: +10%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1843 24 74454 1.6609 0.3341
2.0.7 1822 24 74681 1.6766 0.2999
2.0.6 1815 24 73532 1.6715 0.3046

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding!! Lets keep an eye to see if we can get back to the upstream!

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit a7dd9c8 into master Jul 18, 2021
@nan-wang nan-wang deleted the fix-ci-changed-files branch July 18, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants